Re: [PATCH] D24481: make “#pragma STDC FP_CONTRACT” on by default

Abe Skolnik via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 20 10:43:33 PDT 2016


Abe added a comment.

In https://reviews.llvm.org/D24481#547694, @yaxunl wrote:

> Is it possible to merge cfe/trunk/test/CodeGen/fp-contract-pragma___on-by-default___-O[0-3]___aarch64-backend.c as one and remove cfe/trunk/test/CodeGen/fp-contract-pragma___on-by-default___-O1...3___aarch64-backend.h? They look the same except the RUN commands. Why not using one file with multiple RUn commands?


That seems like a good idea.  I didn`t write it that way yet b/c I was unsure of the semantics of multiple "RUN" command-comments in a single file.  If a single file has e.g.:

  // RUN: %clang_cc1 -triple aarch64 -O1 -S -o - %s | FileCheck %s
  // RUN: %clang_cc1 -triple aarch64 -O2 -S -o - %s | FileCheck %s
  // RUN: %clang_cc1 -triple aarch64 -O3 -S -o - %s | FileCheck %s

... then that will cause 3 compilations and 3 tests, right?


https://reviews.llvm.org/D24481





More information about the cfe-commits mailing list