[PATCH] D24679: [libc++] Fix extern template visibility for Windows
Saleem Abdulrasool via cfe-commits
cfe-commits at lists.llvm.org
Mon Sep 19 11:30:36 PDT 2016
compnerd accepted this revision.
This revision is now accepted and ready to land.
Comment at: include/__config:559
@@ -554,1 +558,3 @@
+# define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS
+# define _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS
> compnerd wrote:
> > Does it make sense for `_LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS` to ever be marked as `__declspec(dllimport)`? The macro is applied on instantiations in the implementation, not the header, so this shouldn't be visible to users.
> It doesn't, which is why I always made it expand to either `__declspec(dllexport)` or empty.
Ugh, I can't match the lines. I misread the two lines and saw the class template instantiation as being defined.
More information about the cfe-commits