[PATCH] D24709: [analyzer] SATestBuild.py: Treat '#' as comment in projectMap.csv

Devin Coughlin via cfe-commits cfe-commits at lists.llvm.org
Sun Sep 18 11:07:25 PDT 2016


dcoughlin created this revision.
dcoughlin added reviewers: zaks.anna, NoQ.
dcoughlin added a subscriber: cfe-commits.

Treat lines in projectMap.csv that start with '#' as comments.

This enables a workflow where projects can be temporarily disabled with a comment describing when they should be turned back on.

https://reviews.llvm.org/D24709

Files:
  utils/analyzer/SATestBuild.py

Index: utils/analyzer/SATestBuild.py
===================================================================
--- utils/analyzer/SATestBuild.py
+++ utils/analyzer/SATestBuild.py
@@ -660,11 +660,17 @@
     print "Completed tests for project %s (time: %.2f)." % \
           (ID, (time.time()-TBegin))
 
+def isCommentCSVLine(Entries):
+  # Treat CSV lines starting with a '#' as a comment.
+  return len(Entries) > 0 and Entries[0].startswith("#")
+
 def testAll(IsReferenceBuild = False, UpdateSVN = False, Strictness = 0):
     PMapFile = open(getProjectMapPath(), "rb")
     try:
         # Validate the input.
         for I in csv.reader(PMapFile):
+            if (isCommentCSVLine(I)):
+                continue
             if (len(I) != 2) :
                 print "Error: Rows in the ProjectMapFile should have 3 entries."
                 raise Exception()
@@ -682,6 +688,8 @@
         # Test the projects.
         PMapFile.seek(0)
         for I in csv.reader(PMapFile):
+            if isCommentCSVLine(I):
+              continue;
             testProject(I[0], int(I[1]), IsReferenceBuild, None, Strictness)
 
         # Add reference results to SVN.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24709.71757.patch
Type: text/x-patch
Size: 1161 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160918/65891248/attachment.bin>


More information about the cfe-commits mailing list