[PATCH] D24289: Add warning when assigning enums to bitfields without an explicit unsigned underlying type

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 15 11:33:26 PDT 2016


rnk added a comment.

In https://reviews.llvm.org/D24289#543874, @thakis wrote:

> Works for me if rnk likes it :-)


Yep, looks good.

> (We could bikeshed on if this should be one of the -Wmicrosoft warnings, but the warning can't be both in -Wall and -Wmicrosoft, so let's don't).


I also don't think it's a good fit for -Wmicrosoft, which is usually trying to warn you that "hey, this is an MS extension!", and not "hey, your Unix code isn't portable to Windows!".


https://reviews.llvm.org/D24289





More information about the cfe-commits mailing list