[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

[Eric Fiselier via cfe-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

This approach looks great. I don't think we need to split things up into separate files. This is exactly how `test_macros.h` should be used.

Feel free to convert as many tests as possible. I've been doing the same to anything I work on.


================
Comment at: test/std/re/re.alg/re.alg.search/grep.pass.cpp:25
@@ -25,2 +24,3 @@
 
+#ifndef TEST_HAS_NO_EXCEPTIONS
 extern "C" void LLVMFuzzerTestOneInput(const char *data)
----------------
I prefer putting the `#if` on the inside of the function so you don't also have to `#ifdef` it out in `main()` below. 



https://reviews.llvm.org/D24562