[PATCH] D24513: [AMDGPU] Expose flat work group size, register and wave control attributes

[Konstantin Zhuravlyov via cfe-commits]

kzhuravl added inline comments.

================
Comment at: include/clang/Basic/Attr.td:1067
@@ +1066,3 @@
+  let Spellings = [GNU<"amdgpu_waves_per_eu">];
+  let Args = [UnsignedArgument<"Min">, VariadicUnsignedArgument<"Max">];
+  let Documentation = [AMDGPUWavesPerEUDocs];
----------------
aaron.ballman wrote:
> Looking at the documentation, are you sure this should be a `VariadicUnsignedArgument`? It seems like this should be an `UnsignedArgument` with the optional bit set. Or can you pass multiple Max values?
You are right. Switched to UnsignedArgument since only one Max is allowed. Thanks.

================
Comment at: lib/Sema/SemaDeclAttr.cpp:6048
@@ -5976,2 +6047,3 @@
       D->setInvalidDecl();
-    } else if (Attr *A = D->getAttr<AMDGPUNumVGPRAttr>()) {
+    } else if (Attr *A = D->getAttr<AMDGPUFlatWorkGroupSizeAttr>()) {
+      Diag(D->getLocation(), diag::err_attribute_wrong_decl_type)
----------------
aaron.ballman wrote:
> This list is getting to the point where we really need to start handling this in Attr.td soon. Are you planning to work on more AMDGPU attributes in the near future?
I agree, and yes, few more attributes will need to be added in the near future. Would it be ok if I change it to start handling in Attr.td after this change, but before other attributes are added?


https://reviews.llvm.org/D24513