[PATCH] D24567: [clang-rename] Merge rename-{at|all} & optimise.

Kirill Bobyrev via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 14 09:04:09 PDT 2016


omtcyfz created this revision.
omtcyfz added reviewers: alexfh, vmiklos.
omtcyfz added a subscriber: cfe-commits.

Having both rename-at and rename-all both seems confusing and introduces unneeded difficulties. After merging rename-at and rename-all maintaining main function wrappers and custom help becomes redundant while CLI becomes less confusing.

D24224 (which was the original patch causing buildbot failures) wasn't aware of bugs caused by passing both `-offset` and `-qualified-name`.

D24224 was reverted and this patch previous diff to disallow both options present within single invocation.

Old and unmaintaned clang-rename unittest is deleted.

https://reviews.llvm.org/D24567

Files:
  clang-rename/USRFindingAction.cpp
  clang-rename/USRFindingAction.h
  clang-rename/tool/ClangRename.cpp
  docs/clang-rename.rst
  test/clang-rename/ClassFindByName.cpp
  test/clang-rename/ClassTestMulti.cpp
  test/clang-rename/ClassTestMultiByName.cpp
  test/clang-rename/ClassTestMultiByNameYAML.cpp
  test/clang-rename/FunctionWithClassFindByName.cpp
  test/clang-rename/Inputs/ClassTestMultiByNameYAMLRenameAll.yaml
  test/clang-rename/Inputs/ClassTestMultiByNameYAMLRenameAt.yaml
  test/clang-rename/Inputs/OffsetToNewName.yaml
  test/clang-rename/Inputs/QualifiedNameToNewName.yaml
  test/clang-rename/InvalidOldName.cpp
  test/clang-rename/NoNewName.cpp
  test/clang-rename/YAMLInput.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24567.71367.patch
Type: text/x-patch
Size: 29886 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160914/851f88a7/attachment-0001.bin>


More information about the cfe-commits mailing list