[PATCH] D24005: [compiler-rt cmake] Support overriding llvm-config query results

Michał Górny via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 13 01:56:42 PDT 2016


mgorny added a comment.

In https://reviews.llvm.org/D24005#540803, @Hahnfeld wrote:

> In https://reviews.llvm.org/D24005#540200, @mgorny wrote:
>
> > And done.
>
>
> I think @beanz meant to actually do the renames for consistency... Sorry for the confusion!


I know but I feel like it's a topic for a separate patch, so I just went back for the current names.

I'm not home right now but furthermore, I suspect that those variables might be actually cross-used between LLVM and compiler-rt, and so we'd have to change them consistently everywhere.


https://reviews.llvm.org/D24005





More information about the cfe-commits mailing list