[PATCH] D24005: [compiler-rt cmake] Support overriding llvm-config query results

[Jonas Hahnfeld via cfe-commits]

Hahnfeld added a reviewer: beanz.
Hahnfeld added a comment.

SGTM, I don't see any drawback


================
Comment at: cmake/Modules/CompilerRTUtils.cmake:200
@@ -199,5 +199,3 @@
   string(REGEX REPLACE "[ \t]*[\r\n]+[ \t]*" ";" CONFIG_OUTPUT ${CONFIG_OUTPUT})
-  list(GET CONFIG_OUTPUT 0 LLVM_BINARY_DIR)
-  list(GET CONFIG_OUTPUT 1 LLVM_TOOLS_BINARY_DIR)
-  list(GET CONFIG_OUTPUT 2 LLVM_LIBRARY_DIR)
-  list(GET CONFIG_OUTPUT 3 LLVM_MAIN_SRC_DIR)
+  list(GET CONFIG_OUTPUT 0 LLVM_OBJ_ROOT)
+  list(GET CONFIG_OUTPUT 1 TOOLS_BINARY_DIR)
----------------
Is `BINARY_DIR` reserved in CMake? Otherwise I would prefer to name this consistently...


https://reviews.llvm.org/D24005