[PATCH] D24446: Implement revision to LWG#2758

[Marshall Clow via cfe-commits]

mclow.lists added inline comments.

================
Comment at: include/string:615
@@ +614,3 @@
+
+// template <class _CharT, class _Traits, class _Tp>
+// struct __can_be_converted_to_string_view : public _LIBCPP_BOOL_CONSTANT(
----------------
These bits will be removed.

================
Comment at: test/std/strings/basic.string/string.modifiers/string_append/string_view_size_size.pass.cpp:10
@@ -10,2 +10,2 @@
 // XFAIL: libcpp-no-exceptions
 // <string>
----------------
This file will be renamed to `T_size_size.pass.cpp`. I didn't do that before uploading the diff because it would make it harder to see just what has changed.

================
Comment at: test/std/strings/basic.string/string.modifiers/string_assign/string_view_size_size.pass.cpp:10
@@ -10,2 +10,2 @@
 // XFAIL: libcpp-no-exceptions
 // <string>
----------------
This file will be renamed to "T_size_size.pass.cpp". I didn't do that before uploading the diff because it would make it harder to see just what has changed.


https://reviews.llvm.org/D24446