[PATCH] D24426: DebugInfo: use llvm::DINode::FlagAlignment to mark forcibly aligned data

Victor Leschuk via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 9 20:29:15 PDT 2016

vleschuk added inline comments.

Comment at: lib/CodeGen/CGDebugInfo.cpp:979
@@ -978,4 +978,3 @@
 llvm::DIType *
-CGDebugInfo::createFieldType(StringRef name, QualType type, SourceLocation loc,
-                             AccessSpecifier AS, uint64_t offsetInBits,
-                             llvm::DIFile *tunit, llvm::DIScope *scope,
+CGDebugInfo::createFieldType(StringRef Name, QualType Type, SourceLocation Loc,
+                             AccessSpecifier AS, uint64_t OffsetInBits,
aprantl wrote:
> Could you please do the re-formatting as a separate NFC commit? No need to for a separate review.
> This makes reviewing, cherry-picking, and bisection much easier.
Sure, sorry for that. Will revert.


More information about the cfe-commits mailing list