[PATCH] D24374: [libc++] Avoid <memory> include in locale_win32.h

Shoaib Meenai via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 9 14:00:01 PDT 2016

smeenai updated this revision to Diff 70899.
smeenai added a comment.

Correcting support_win32.cpp



Index: src/support/win32/locale_win32.cpp
--- src/support/win32/locale_win32.cpp
+++ src/support/win32/locale_win32.cpp
@@ -10,6 +10,11 @@
 #include <locale>
 #include <cstdarg> // va_start, va_end
+#include <memory>
+#include <type_traits>
+typedef _VSTD::remove_pointer<locale_t>::type __locale_struct;
+typedef _VSTD::unique_ptr<__locale_struct, decltype(&uselocale)> __locale_raii;
 // FIXME: base currently unused. Needs manual work to construct the new locale
 locale_t newlocale( int mask, const char * locale, locale_t /*base*/ )
Index: include/support/win32/locale_win32.h
--- include/support/win32/locale_win32.h
+++ include/support/win32/locale_win32.h
@@ -17,7 +17,6 @@
 #include "support/win32/support.h"
 #include "support/win32/locale_mgmt_win32.h"
 #include <stdio.h>
-#include <memory>
 lconv *localeconv_l( locale_t loc );
 size_t mbrlen_l( const char *__restrict s, size_t n,
@@ -34,13 +33,10 @@
                      size_t nwc, size_t len, mbstate_t *__restrict ps, locale_t loc);
 wint_t btowc_l( int c, locale_t loc );
 int wctob_l( wint_t c, locale_t loc );
-typedef _VSTD::remove_pointer<locale_t>::type __locale_struct;
-typedef _VSTD::unique_ptr<__locale_struct, decltype(&uselocale)> __locale_raii;
 decltype(MB_CUR_MAX) MB_CUR_MAX_L( locale_t __l )
-  __locale_raii __current( uselocale(__l), uselocale );
-  return MB_CUR_MAX;
+  return ___mb_cur_max_l_func(__l);
 // the *_l functions are prefixed on Windows, only available for msvcr80+, VS2005+

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24374.70899.patch
Type: text/x-patch
Size: 1660 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160909/ca666909/attachment-0001.bin>

More information about the cfe-commits mailing list