[PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

Keno Fischer via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 8 20:30:14 PDT 2016


loladiro created this revision.
loladiro added reviewers: EricWF, mclow.lists.
loladiro added a subscriber: cfe-commits.
loladiro set the repository for this revision to rL LLVM.

Without this, unique_ptr is not constant initialized. I've added a test to that extent.
Unfortunately, I believe there's additional work required for C++11, since unique_ptr
uses std::forward internally which is not constexpr until C++14. Doing something about
that is not part of this patch. unique_ptr not being constant initialized is particularly problematic
because it is in libstdc++, so there's applications that rely on this behavior.

Repository:
  rL LLVM

https://reviews.llvm.org/D24372

Files:
  include/memory
  test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/constinit.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24372.70777.patch
Type: text/x-patch
Size: 16065 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160909/4fe4468a/attachment-0001.bin>


More information about the cfe-commits mailing list