[PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

Anna Zaks via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 8 11:19:37 PDT 2016

zaks.anna added a comment.

> I don't see the point of adding another flag to control this when we already have a perfectly good set of 

>  flags that already do the right thing -- that takes us three levels deep in flags overriding the behavior of 

>  other flags, and I don't see how it actually helps our users in any way.

Going with silently linking the sanitizer runtimes when -nostdlib is passed will cause regressions in user experience. They will start getting inexplicable run time failures instead of build failures. Which solution do you propose to fix this problem?

This specific situation comes up often on internal mailing lists, so we should not go for a solution that regresses the behavior on Darwin.


More information about the cfe-commits mailing list