[clang-tools-extra] r280839 - Resubmit "Add a test for clang-tidy using the clang-cl driver."

Ahmed Bougacha via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 8 09:44:54 PDT 2016


On Thu, Sep 8, 2016 at 9:38 AM, Zachary Turner <zturner at google.com> wrote:
> What happens if you put the %s in quotes?

Same error

-Ahmed

>
> On Thu, Sep 8, 2016 at 9:32 AM Ahmed Bougacha <ahmed.bougacha at gmail.com>
> wrote:
>>
>> Hi Zachary,
>>
>> This test has been failing on some OS X machines, e.g.:
>>
>> http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/21470/consoleFull#19036563798254eaf0-7326-4999-85b0-388101f2d404
>>
>> My hypothesis is that the %s path ('/Users/...')  is somehow
>> interpreted as a '/U' by the clang-cl driver, causing the cryptic
>> 'Error while processing /Users/.../clang-cl-driver.cpp' error  (as the
>> test succeeds when run from other paths: /tmp/, /Volumes/).
>> Does that make sense?  Any suggestions on how to fix?
>>
>> Thanks!
>> -Ahmed
>>
>>
>> On Wed, Sep 7, 2016 at 11:28 AM, Zachary Turner via cfe-commits
>> <cfe-commits at lists.llvm.org> wrote:
>> > Author: zturner
>> > Date: Wed Sep  7 13:28:42 2016
>> > New Revision: 280839
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=280839&view=rev
>> > Log:
>> > Resubmit "Add a test for clang-tidy using the clang-cl driver."
>> >
>> > This was originally reverted because the patch on the clang
>> > tooling side was reverted.  That patch is being resubmitted,
>> > so this patch is resubmitted as well.
>> >
>> > Added:
>> >     clang-tools-extra/trunk/test/clang-tidy/clang-cl-driver.cpp
>> >
>> > Added: clang-tools-extra/trunk/test/clang-tidy/clang-cl-driver.cpp
>> > URL:
>> > http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/clang-cl-driver.cpp?rev=280839&view=auto
>> >
>> > ==============================================================================
>> > --- clang-tools-extra/trunk/test/clang-tidy/clang-cl-driver.cpp (added)
>> > +++ clang-tools-extra/trunk/test/clang-tidy/clang-cl-driver.cpp Wed Sep
>> > 7 13:28:42 2016
>> > @@ -0,0 +1,17 @@
>> > +// RUN: clang-tidy -checks=-*,modernize-use-nullptr %s --
>> > --driver-mode=cl /DTEST1 /DFOO=foo /DBAR=bar | FileCheck
>> > -implicit-check-not="{{warning|error}}:" %s
>> > +int *a = 0;
>> > +// CHECK: :[[@LINE-1]]:10: warning: use nullptr
>> > +#ifdef TEST1
>> > +int *b = 0;
>> > +// CHECK: :[[@LINE-1]]:10: warning: use nullptr
>> > +#endif
>> > +#define foo 1
>> > +#define bar 1
>> > +#if FOO
>> > +int *c = 0;
>> > +// CHECK: :[[@LINE-1]]:10: warning: use nullptr
>> > +#endif
>> > +#if BAR
>> > +int *d = 0;
>> > +// CHECK: :[[@LINE-1]]:10: warning: use nullptr
>> > +#endif
>> >
>> >
>> > _______________________________________________
>> > cfe-commits mailing list
>> > cfe-commits at lists.llvm.org
>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


More information about the cfe-commits mailing list