[PATCH] D24192: [clang-refactor] introducing clang-refactor

Marek Kurdej via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 8 05:41:07 PDT 2016

curdeius added inline comments.

Comment at: clang-refactor/driver/ModuleManager.h:14-20
@@ +13,9 @@
+#include "clang/Basic/LLVM.h"
+#include "llvm/ADT/StringRef.h"
+#include <string>
+#include <unordered_map>
+#include <vector>
+#include "core/RefactoringModule.h"
I thought that idea behind sorting includes using clang-format is to avoid handling groups and order manually.
I don't think that there is any policy prohibiting separating includes into groups, but AFAIK, there is one that says that STL includes should be the last (you should include in order from the most specific to the most generic, i.e. subproject, clang, llvm, STL).


More information about the cfe-commits mailing list