[PATCH] D24314: [libc++] Clean up MSVC support

Shoaib Meenai via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 7 14:22:10 PDT 2016


smeenai added inline comments.

================
Comment at: include/support/win32/support.h:48
@@ -47,2 +47,3 @@
 #if defined(_LIBCPP_MSVCRT)
+#if _VC_CRT_MAJOR_VERSION < 14
 #define snprintf _snprintf
----------------
EricWF wrote:
> Maybe fold these to `#if`'s into `#if defined(_VC_CRT_MAJOR_VERSION) && _VC_CRT_MAJOR_VERSION < 14`.
Good idea.


https://reviews.llvm.org/D24314





More information about the cfe-commits mailing list