[PATCH] D24268: Traversing template paramter lists of DeclaratorDecls and/or TagDecls.

Richard Smith via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 6 18:18:40 PDT 2016

rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

This patch looks great, thank you! Do you have an SVN account or do you need someone to commit this for you?

Comment at: unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:729
@@ -645,2 +728,2 @@
   EXPECT_TRUE(matches("template<int T> struct C {}; C<42> c;",
I'd view the `hasAncestor` failure as an indirect symptom of the root problem, which is that we were failing to traverse some nodes. I prefer the new `hasName` test, since it more directly checks for that immediate problem.


More information about the cfe-commits mailing list