r253269 - Make FP_CONTRACT ON the default.

[Hal Finkel via cfe-commits]

Hi Steve, et al.,

It looks like this crasher was fixed in r254573. Should we move forward with recommitting this now?

Thanks again,
Hal

----- Original Message -----
> From: "Manuel Klimek" <klimek at google.com>
> To: "Hal Finkel" <hfinkel at anl.gov>, "Renato Golin" <renato.golin at linaro.org>
> Cc: "Clang Commits" <cfe-commits at lists.llvm.org>
> Sent: Tuesday, November 17, 2015 9:47:11 AM
> Subject: Re: r253269 - Make FP_CONTRACT ON the default.
> 
> 
> Reverted in r253337. Failing test case in commit message.
> 
> 
> 
> On Tue, Nov 17, 2015 at 4:39 PM Manuel Klimek < klimek at google.com >
> wrote:
> 
> Repro:
> float foo(float U, float base, float cell) { return (U = 2 * base) -
> cell; }
> Preparing rollback of the CL.
> 
> 
> On Tue, Nov 17, 2015 at 2:46 PM Manuel Klimek < klimek at google.com >
> wrote:
> 
> 
> 
> Note that due to this change we're hitting an assert at
> lib/CodeGen/CGExprScalar.cpp:2570 in llvm::Value
> *tryEmitFMulAdd(const (anonymous namespace)::BinOpInfo &, const
> clang::CodeGen::CodeGenFunction &, clang::CodeGen::CGBuilderTy &,
> bool): LHSBinOp->getNumUses(
> ) == 0 && "Operations with multiple uses shouldn't be contracted."
> 
> 
> Don't have a small repro yet :(
> 
> 
> On Tue, Nov 17, 2015 at 1:39 PM Hal Finkel via cfe-commits <
> cfe-commits at lists.llvm.org > wrote:
> 
> 
> ----- Original Message -----
> > From: "Renato Golin via cfe-commits" < cfe-commits at lists.llvm.org >
> > To: "Stephen Canon" < scanon at apple.com >
> > Cc: "Clang Commits" < cfe-commits at lists.llvm.org >
> > Sent: Tuesday, November 17, 2015 3:51:23 AM
> > Subject: Re: r253269 - Make FP_CONTRACT ON the default.
> > 
> > On 16 November 2015 at 23:09, Stephen Canon via cfe-commits
> > < cfe-commits at lists.llvm.org > wrote:
> > > Author: scanon
> > > Date: Mon Nov 16 17:09:11 2015
> > > New Revision: 253269
> > > 
> > > URL: http://llvm.org/viewvc/llvm-project?rev=253269&view=rev
> > > Log:
> > > Make FP_CONTRACT ON the default.
> > > 
> > > Differential Revision: D14200
> > 
> > Hi Stephen,
> > 
> > It seems your commit in the blame list is the only one that affects
> > AArch64 directly:
> > 
> > http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/2388
> > 
> > I haven't bisected yet, but would be good if you could try those
> > tests
> > locally, just to make sure it wasn't your commit, and revert if it
> > was, to fix offline.
> 
> The test suite already has logic to add -ffp-contract=off on PowerPC
> so that we can compare to the binary outputs. We may need to do this
> now for all targets, at least until be come up with a better
> solution.
> 
> -Hal
> 
> > 
> > cheers,
> > --renato
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> > 
> 
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory