[PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

Kirill Bobyrev via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 6 05:18:41 PDT 2016

omtcyfz added inline comments.

Comment at: clang-rename/USRFindingAction.h:23
@@ -19,1 +22,3 @@
+using llvm::ArrayRef;
alexfh wrote:
> No using declarations in headers, please. Also, since your code is in the clang namespace, you can include clang/Basic/LLVM.h that re-declares ArrayRef in namespace clang.
Ah, I didn't think why this might be bad at first, but now I see.


More information about the cfe-commits mailing list