[PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2
Eric Fiselier via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 6 04:19:12 PDT 2016
EricWF added a comment.
This looks great. Two comments:
1. The declarations should be used in both the inline and external pthread implementation. They also need visibility declarations.
2. Why can't we use the inline implementation to implement `external_threads.cpp`?
I took a stab at it here <https://gist.github.com/EricWF/0edfd18c22cd50a5f34fd11674f4eda9>.
After that this LGTM.
Comment at: lib/CMakeLists.txt:211
@@ +210,3 @@
When this is building as a shared library it needs to do the `-nodefaultlibs` dance to prevent linking to libstdc++.so or other unwanted system libraries.
More information about the cfe-commits