[PATCH] D24087: [lit] Allow more file extensions for test cases.

Logan Chien via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 6 03:43:15 PDT 2016

logan added inline comments.

Comment at: test/libcxx/test/format.py:69
@@ +68,3 @@
+        name_root, name_ext = os.path.splitext(name)
+        is_sh_test = name_root.endswith('.sh')
+        is_pass_test = name_root.endswith('.pass')
EricWF wrote:
> Since we only support `.sh.XXX` tests let's only loosen the restriction there for now.
Do you mean that it is preferred to revert following two lines back?  For example:

    is_sh_test = name_root.endswith('.sh')
    is_pass_test = name.endswith('.pass.cpp')
    is_fail_test = name.endswith('.fail.cpp')
    assert is_sh_test or name_ext == '.cpp'


More information about the cfe-commits mailing list