[PATCH] D21506: [analyzer] Block in critical section

Zoltán Dániel Török via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 5 12:48:11 PDT 2016

zdtorok marked 8 inline comments as done.
zdtorok added a comment.

Thank you for both of your comments and feedbacks! Also please forgive me for my (really) late response. Please have a look at my fixes and the new attached diff. Thanks!

Comment at: lib/StaticAnalyzer/Checkers/BlockInCriticalSectionChecker.cpp:85
@@ +84,3 @@
+void BlockInCriticalSectionChecker::checkPreCall(const CallEvent &Call,
+                                                 CheckerContext &C) const {
zaks.anna wrote:
> Why is handling of unlock in preCall?
For some reason first I thought it's better for performance reasons - but now I've changed it to postCall.



More information about the cfe-commits mailing list