[PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 2 12:15:15 PDT 2016


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with one small test case nit.


================
Comment at: test/Parser/ms-square-bracket-attributes.mm:43
@@ +42,3 @@
+// expected-error at +1 {{expected '('}}
+[uuid{"000000A0-0000-0000-C000-000000000049"}] struct T {};
+
----------------
For giggles, can you also add:
```
// expected-error at +1 {{expected ')'}}
[uuid("000000A0-0000-0000-C000-000000000049"}] struct T {};
```


https://reviews.llvm.org/D23895





More information about the cfe-commits mailing list