[PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

Filipe Cabecinhas via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 30 14:16:39 PDT 2016


Haha, the joke is on me. I had the opposite opinion two years ago (I
guess by virtue of working on the sanitizers for a while, I've come to
see them as default libs?).

Making the behavior more consistent is good, and the r218541
discussion (+220455) makes me think your patch is good. We end up
having *some* weird behavior when mixing this type of flags. But I
think Bruno's suggestion to warn (I think maybe documenting it is
enough, though) might be good.

Thank you,

 Filipe


On Tue, Aug 30, 2016 at 9:15 PM, Bruno Cardoso Lopes via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> bruno added a subscriber: bruno.
> bruno added a comment.
>
> Regardless of the way we decide to go with this, it would be nice if a driver level warning is used to tell users about any  non-obvious assumed behavior when these flags are used together.
>
>
> https://reviews.llvm.org/D24048
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


More information about the cfe-commits mailing list