[PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

Mehdi Amini via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 30 13:12:40 PDT 2016


Alternatively, since you only need the presence of a file named libLTO for the driver to do its magic, test can create an empty file named libLTO.dylib and use the  -ccc-install-dir to make sure the right flag is passed.

> On Aug 30, 2016, at 10:40 AM, Vedant Kumar <vsk at apple.com> wrote:
> 
> vsk created this revision.
> vsk added a reviewer: bruno.
> vsk added a subscriber: cfe-commits.
> Herald added a subscriber: mehdi_amini.
> 
> Running 'check-clang' on a stock checkout of llvm+clang doesn't work on Darwin, because test/Driver/darwin-ld-lto.c can't find libLTO.dylib. Add libLTO as a clang test dependency on Darwin to fix the problem.
> 
> Note: We don't have this issue with check-all because libLTO is in the test-depends target.
> 
> https://reviews.llvm.org/D24042
> 
> Files:
>  test/CMakeLists.txt
> 
> Index: test/CMakeLists.txt
> ===================================================================
> --- test/CMakeLists.txt
> +++ test/CMakeLists.txt
> @@ -82,6 +82,10 @@
>   endif()
> endif()
> 
> +if(APPLE)
> +  list(APPEND CLANG_TEST_DEPS LTO)
> +endif()
> +
> add_custom_target(clang-test-depends DEPENDS ${CLANG_TEST_DEPS})
> set_target_properties(clang-test-depends PROPERTIES FOLDER "Clang tests")
> 
> 
> 
> <D24042.69723.patch>



More information about the cfe-commits mailing list