[PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

[Eric Fiselier via cfe-commits]

EricWF added a comment.

In https://reviews.llvm.org/D23831#528637, @halyavin wrote:

> Thank you for fixing most of warnings. Now it says "cc1plus: warning: unrecognized command line option "-Wno-c++14-compat"" though.


No worries, it was driving me nuts. The addition of `-Wno-c++14-compat` and `-Wno-literal-suffix` targets GCC 5.x+ and 7.0+ respectively. It's almost impossible to detect the validity of -Wno-<warning> flags,  I fear these warnings are here to stay for older GCC versions. Thankfully GCC does not emit a "unrecognized command line option" diagnostic on otherwise warning-free code, so if we can fix the other diagnostics we can suppress this one.


https://reviews.llvm.org/D23831