[PATCH] D23944: Parsing MS pragma intrinsic

Albert Gutowski via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 29 15:30:04 PDT 2016


agutowski added inline comments.

================
Comment at: lib/Parse/ParsePragma.cpp:2164
@@ +2163,3 @@
+
+  bool SuggestIntrinH = !PP.isMacroDefined("__INTRIN_H");
+
----------------
aaron.ballman wrote:
> Is this safe to rely on? I'm not familiar with how we do our intrinsics, but it's spelled `__INTRIN_H_` in MSVC 2015, but perhaps we only care about intrin.h from Clang?
I guess we only care about intrin.h from Clang - as far as I can see, MSVC's intrin.h contains only declarations, so including it won't change anything most of the time if the intrinsic isn't implemented in Clang.


https://reviews.llvm.org/D23944





More information about the cfe-commits mailing list