[PATCH] D23918: [clang-tidy docs] Add missing option docs.

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 29 01:27:29 PDT 2016


hokein added inline comments.

================
Comment at: docs/clang-tidy/checks/google-readability-namespace-comments.rst:11
@@ +10,3 @@
+
+Options
+-------
----------------
Eugene.Zelenko wrote:
> This documentation is redirect, so options description should be moved to llvm-namespace-comment.rst.
Oh, didn't notice it. Done.

================
Comment at: docs/clang-tidy/checks/modernize-replace-auto-ptr.rst:79
@@ +78,3 @@
+
+   A string specifying which include-style is used, `llvm` or `google`.
+   `llvm` by default.
----------------
Eugene.Zelenko wrote:
> `llvm` should be on this line. See other similar descriptions.
If we put it into one line, the line's length will exceed 80 characters.

================
Comment at: docs/clang-tidy/checks/readability-implicit-bool-cast.rst:106
@@ +105,3 @@
+
+   When non-zero, the check will allow conditional integer casts.
+   `0` by default.
----------------
Eugene.Zelenko wrote:
> Looks like `0` by should fit 80 characters. Same below.
It exceeds 80 characters by an extra character...


https://reviews.llvm.org/D23918





More information about the cfe-commits mailing list