[PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 24 12:33:09 PDT 2016


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

LG with a couple of nits. Do you need me to submit the patch for you? (If yes, I can fix the doc myself)


================
Comment at: docs/clang-tidy/checks/llvm-header-guard.rst:8
@@ +7,3 @@
+
+For the user-facing documentation see: http://clang.llvm.org/extra/clang-tidy/checks/llvm-header-guard.html
+
----------------
This line is not needed here (it's a self-reference).

================
Comment at: docs/clang-tidy/checks/llvm-header-guard.rst:10
@@ +9,3 @@
+
+The check supports these options:
+``HeaderFileExtensions``: a comma-separated list of filename extensions of header files (The filename extension should not contain "." prefix). ",h,hh,hpp,hxx" by default. For extension-less header files, using an empty string or leaving an empty string between "," if there are other filename extensions.
----------------
Should be

  Options
  -------

  .. option:: HeaderFileExtensions
  
    ...


https://reviews.llvm.org/D20512





More information about the cfe-commits mailing list