[PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

[Alexander Kornienko via cfe-commits]

alexfh added a comment.

Thank you! I've just noticed that we had completely ignored the actual docs =\ See the inline comment for details.


================
Comment at: clang-tidy/llvm/HeaderGuardCheck.h:20
@@ -19,1 +19,3 @@
 /// Finds and fixes header guards that do not adhere to LLVM style.
+/// The check supports these options:
+///   - `HeaderFileExtensions`: a comma-separated list of filename extensions of
----------------
Please add 

  /// For the user-facing documentation see:
  /// http://clang.llvm.org/extra/clang-tidy/checks/llvm-header-guard.html

and copy the rest of the comment to the corresponding .rst file with proper formatting (see docs/clang-tidy/checks/misc-argument-comment.rst for an example).

================
Comment at: clang-tidy/utils/HeaderFileExtensionsUtils.h:44
@@ -43,1 +43,3 @@
 
+/// \brief Decides whether a file has a header file extension
+bool isHeaderFileExtension(StringRef FileName,
----------------
nit: Add a trailing period.


https://reviews.llvm.org/D20512