[PATCH] D23730: [GraphTraits] Replace all NodeType usage with NodeRef

Tim Shen via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 22 12:58:39 PDT 2016


timshen added a comment.

In https://reviews.llvm.org/D23730#522396, @dblaikie wrote:

> Not all of these already had NodeRef implemented - that implies that some algorithms weren't using NodeRef before this change, or that these traits are unused? I thought the plan was to migrate each algorithm then just do a strict cleanup. Did that not pan out/some other aspects I'm forgetting?


I think those traits are unused. Notice that by merely removing "NodeType *" declarations, the build/tests doesn't break, so at least they are not covered by the tests.


https://reviews.llvm.org/D23730





More information about the cfe-commits mailing list