[PATCH] D23555: [analyzer] CloneDetector now checks template arguments of function calls.

Raphael Isemann via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 19 07:18:23 PDT 2016


teemperor marked 3 inline comments as done.

================
Comment at: lib/Analysis/CloneDetection.cpp:164
@@ +163,3 @@
+        for (unsigned i = 0; i < Args->size(); ++i) {
+          Args->get(i).print(Context.getLangOpts(), OS);
+        }
----------------
NoQ wrote:
> We don't discriminate between `foo<A, AA>()` and `foo<AA, A>()` here, because in both cases the stuff we hash gets concatenated to `AAA`. Just thought that we might be having this common problem everywhere, even though it barely shows up "in real life".
Yes, that could be a problem. I'll fix this issue here in this patch and the others in another patch.


https://reviews.llvm.org/D23555





More information about the cfe-commits mailing list