[PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

Saleem Abdulrasool via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 17 10:16:53 PDT 2016


compnerd added a subscriber: compnerd.

================
Comment at: CMakeLists.txt:139
@@ -138,1 +138,3 @@
 option(LIBCXX_HAS_PTHREAD_API "Ignore auto-detection and force use of pthread API" OFF)
+option(LIBCXX_HAS_EXTERNAL_THREAD_API
+  "Build libc++ with an externalized threading API.
----------------
Can you use `cmake_dependent_option` here instead please?

================
Comment at: include/__config:830
@@ -829,1 +829,3 @@
+    !defined(_LIBCPP_HAS_THREAD_API_PTHREAD) && \
+    !defined(_LIBCPP_HAS_THREAD_API_EXTERNAL)
 # if defined(__FreeBSD__) || \
----------------
clang-format?


https://reviews.llvm.org/D21968





More information about the cfe-commits mailing list