[PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

Yaxun Liu via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 16 12:17:53 PDT 2016


yaxunl added inline comments.

================
Comment at: lib/CodeGen/CodeGenModule.cpp:101
@@ -100,3 +100,3 @@
   DoubleTy = llvm::Type::getDoubleTy(LLVMContext);
   PointerWidthInBits = C.getTargetInfo().getPointerWidth(0);
   PointerAlignInBytes =
----------------
joey wrote:
> What if you create a new function in TargetInfo called getMaxPointerWidth(unsigned AddrSpace), and call that here? That would by default just call 'getPointerWidth', but in your AMDGPU TargetInfo you can override that.
> That feels more generic.
Thanks for your suggestion. There are some other changes needed in addition to that.


https://reviews.llvm.org/D23361





More information about the cfe-commits mailing list