[PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

[Aaron Ballman via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM with one minor nit (you can fix it during the commit).


================
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35
@@ +34,3 @@
+  auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr(
+      hasDeclaration(decl(anyOf(isPrivate(), isProtected())))))));
+
----------------
Perhaps: `unless(isPublic())` instead of `anyOf(isPrivate(), isProtected())`?


https://reviews.llvm.org/D23343