[PATCH] D23531: [Darwin] Stop linking libclang_rt.eprintf.a

Chris Bieneman via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 15 15:51:41 PDT 2016


beanz created this revision.
beanz added reviewers: ddunbar, bob.wilson.
beanz added a subscriber: cfe-commits.

The eprintf library was added before the general OS X builtins library existed as a place to store one builtin function. Since we have for several years had an actual mandated builtin library for OS X > 10.5, we should just merge eprintf into the main library.

This change will resolve PR28855.

As a follow up I'll also patch compiler-rt to not generate the eprintf library anymore.

https://reviews.llvm.org/D23531

Files:
  lib/Driver/ToolChains.cpp

Index: lib/Driver/ToolChains.cpp
===================================================================
--- lib/Driver/ToolChains.cpp
+++ lib/Driver/ToolChains.cpp
@@ -483,8 +483,6 @@
     if (isMacosxVersionLT(10, 5)) {
       AddLinkRuntimeLib(Args, CmdArgs, "libclang_rt.10.4.a");
     } else {
-      if (getTriple().getArch() == llvm::Triple::x86)
-        AddLinkRuntimeLib(Args, CmdArgs, "libclang_rt.eprintf.a");
       AddLinkRuntimeLib(Args, CmdArgs, "libclang_rt.osx.a");
     }
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D23531.68098.patch
Type: text/x-patch
Size: 492 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160815/ad193955/attachment.bin>


More information about the cfe-commits mailing list