[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

Piotr Padlewski via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 14 01:25:06 PDT 2016

Prazek accepted this revision.
Prazek added a comment.
This revision is now accepted and ready to land.

LGTM with the fixes of docs.

Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:31
@@ +30,3 @@
+      Result.Nodes.getNodeAs<DeclRefExpr>("randomGenerator");
+  diag(MatchedDecl->getLocation(), "rand() function has limited randomness, "
+                                   "use C++11 random library instead");
I am not sure about the diagnostics convention, it is possible that you should replace comma with semicolon.



More information about the cfe-commits mailing list