[PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

Alexander Kornienko via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 13 10:35:15 PDT 2016

alexfh added inline comments.

Comment at: lib/Tooling/JSONCompilationDatabase.cpp:119
@@ -115,1 +118,3 @@
     StringRef EscapedCommandLine) {
+#if defined(LLVM_ON_WIN32)
+  llvm::BumpPtrAllocator Alloc;
As noted on D23409, this will likely break mingw compatibility in clang on windows. We should either add a sort of auto-detection of the command line format, or extend the JSON compilation database with a way to specify the command line format used (or as Reid suggests, specify a list of arguments, but this should be done in a backward-compatible way).


More information about the cfe-commits mailing list