[PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.
Alexander Shaposhnikov via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 12 10:04:45 PDT 2016
alexshap added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:217
@@ +216,3 @@
+ // then large field indices to small field indices
+ return std::make_tuple(Align, -Size,
+ Field ? -static_cast<int>(Field->getFieldIndex())
> I think std::tie is the more idiomatic way to do this (not that I had it right before either). You get less copying of values, though that doesn't matter much for the types we are using here.
std::tie expects an l-value for 2nd argument,
so it doesn't compile (if i switch to std::tie):
no matching function for call to 'tie'
return std::tie(Align, -Size,
candidate function [with _Tp = <const clang::CharUnits, clang::CharUnits,
int>] not viable: expects an l-value for 2nd argument
tie(_Tp&... __t) _NOEXCEPT
More information about the cfe-commits