[PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

Adhemerval Zanella via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 12 08:27:27 PDT 2016

zatrazz added a comment.

In https://reviews.llvm.org/D23420#513824, @jroelofs wrote:

> In https://reviews.llvm.org/D23420#513820, @zatrazz wrote:
> > Yes, although in pratice for shared libraries this is not an issue (at least on Linux with current linker strategies). And I open for suggestion on how to proceed in this case since we have some other options:
> >
> > 1. Add the required soft-sp implementations when building for Linux (this might happen not only on aarch64, but any other ABI that defines long double using fallback soft-fp)
> Are the softfp symbols you need not contained in libgcc.a?

Good call, I think just using 'lgcc' should be suffice. I will change the patch.


More information about the cfe-commits mailing list