[PATCH] D23409: Make clang-tidy work with clang-cl
Alexander Kornienko via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 11 13:31:19 PDT 2016
alexfh added a comment.
In https://reviews.llvm.org/D23409#512819, @zturner wrote:
> In https://reviews.llvm.org/D23409#512745, @zturner wrote:
> > In https://reviews.llvm.org/D23409#512720, @aaron.ballman wrote:
> > > Patch generally LGTM, though I wonder if there's a way we can add test coverage for this.
> > I'd imagine we can just enable the clang-tidy test suite on Windows (I'm assuming it's currently disabled). I'll look into it.
> Actually yea I'm not sure how to go about doing this. All the existing tests are written to use GCC style command line, and it seems unreasonable to add a cl style command line variant of every single test. maybe alexfh@ or someone has a suggestion.
I think a single test for cl-style command line variant should be enough, if it verifies different aspects of the transformation of the command line (`/` prefix for flags, `\` path separators, different quoting, what else?).
More information about the cfe-commits