[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes
Ben Harper via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 10 23:46:55 PDT 2016
Is there anything I can do to make reviewing easier?
For example, I could run my code vs master on some large code bases (eg
linux kernel, chromium), and verify that there are no crashes, and also
manually spot check some results.
On Wed, 20 Jul 2016 at 21:43 Ben Harper <rogojin at gmail.com> wrote:
> bmharper added a comment.
> Comment at: lib/Format/WhitespaceManager.cpp:95
> @@ -97,2 +94,3 @@
> std::sort(Changes.begin(), Changes.end(),
> + calculateScopeLevel();
> berenm wrote:
> > Maybe we could spare the computation if we aren't going to align
> > Is it better for clarity to always compute additional information?
> @djasper what's the Clang way to do?
> That's a good point. One certainly could elide that if alignment was
> turned off. I think so long as it was mentioned in the comments of the
> ScopeLevel member variable, it would be OK to do so. However, I'll also
> just defer this decision to @djasper.
> rL LLVM
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits