r278264 - Reapply [Sema] Add sizeof diagnostics for bzero

Bruno Cardoso Lopes via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 10 14:36:01 PDT 2016

Hi Joerg,

> Given that bzero is pretty much non-standard at this point, I strongly
> dislike the approach of checking only the function name.

Thanks for the feedback. bzero it's widely used though, I think it's a
usability win to perform a diagnostic here, despite bzero being

Is there any additional reason why you dislike it or additional checks
you suggest? IIUC, Sema::CheckMemaccessArguments already checks if the
number of arguments is the same and if they are indeed what they're
supposed to be.

If deprecation is the main issue here, shouldn't clang emit warnings
to mention 'bzero' deprecation then?

Bruno Cardoso Lopes

More information about the cfe-commits mailing list