[PATCH] D23279: clang-reorder-fields

Kirill Bobyrev via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 10 11:02:11 PDT 2016

omtcyf0 added a subscriber: omtcyf0.
omtcyf0 added a comment.

In https://reviews.llvm.org/D23279#511439, @bcraig wrote:

> I will agree that compilation databases are a (mostly) necessary, but not sufficient part of the solution.  The refactoring tool will need to be careful about changing the structure definition.  It needs to remember (across TUs) what the old definition was and what the desired definition is, so that it can correctly fix up the uses and initializer lists.  If it saves the files too aggressively, then there will be some serious problems.
> So lots of things for @alexshap to work on.

Well, multi-TU support is needed for many tools and it is far beyond one tool implementation details if we want it to be nice. I want to have multi-TU support in the clang-refactor, but it is still in designing stage at the moment. At first, one translation unit might be okay, though.



More information about the cfe-commits mailing list