[PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

Ben Langmuir via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 9 09:09:29 PDT 2016

benlangmuir added a comment.

Sorry for the delay, I apparently forgot to hit submit. Replied inline.

Comment at: lib/Frontend/CompilerInstance.cpp:1491
@@ +1490,3 @@
+            false/*IsExplicit*/).first;
+        Module->IsSystem = true;
+        Module->IsFromModuleFile = true;
manmanren wrote:
> benlangmuir wrote:
> > Why do we assume this?
> Thanks for reviewing so quickly!
> I was not sure about what value we should set IsSystem. Since we are mostly prebuilding system modules, I assumed "true". Do you have any suggestion here?
I guess treating it as system is the more forgiving option, so I'm okay with keeping it.  It's probably worth adding a comment that this is not always the correct choice, since it can affect diagnostics, etc.


More information about the cfe-commits mailing list