[PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 9 06:17:20 PDT 2016

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, but I am also not well-versed in vector operations, so you may want to wait a day or two for @uweigand or someone else to sign off as well.

Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8681-8683
@@ -8680,5 +8676,3 @@
-    return CheckVectorOperands(LHS, RHS, Loc, IsCompAssign,
-                               /*AllowBothBool*/true,
-                               /*AllowBoolConversions*/false);
vbyakovl wrote:
> aaron.ballman wrote:
> > Are you saying that calling `CheckVectorOperands` was always incorrect? Or that it's no longer required because it should be fully covered by `checkVectorShift`? Because the two methods do considerably different checking, and I would have expected there to be more behavioral differences in the tests by removing the call to `CheckVectorOperands` that suggests there are tests missing.
> Yes, calling CheckVectorOperands is not correct here because it compares operand types to be the same. For shift it is not true.
Thank you for clarifying!



More information about the cfe-commits mailing list