[PATCH] D23272: [analyzer][Rewrite] Fix boxes and shadows in HTML rewrites in Firefox.

Artem Dergachev via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 9 01:41:56 PDT 2016

NoQ added inline comments.

Comment at: lib/Rewrite/HTMLRewrite.cpp:304
@@ -303,2 +303,3 @@
+          "  border-radius:5px;  box-shadow:1px 1px 7px #000; "
           "  -webkit-border-radius:5px;  -webkit-box-shadow:1px 1px 7px #000; "
           "position: absolute; top: -1em; left:10em; z-index: 1 } \n"
a.sidorin wrote:
> Should we remove '-webkit'-prefixed options as well? AFAIR, non-prefixed options should be supported by Webkit. Could you check with Chrome/Safari?
All modern browsers should support the unprefixed property and work well without the prefixed property, but i'm not sure if there ever existed older browsers that used to support only the prefixed property. So i think i'm playing safe.

Also, i read that they recommend putting prefixed properties //before// unprefixed, because prefixed properties should override unprefixed properties whenever supported; i'd fix that.


More information about the cfe-commits mailing list