[PATCH] D23241: Add the notion of deferred diagnostics.

Artem Belevich via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 8 11:25:47 PDT 2016

tra added inline comments.

Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2886
@@ +2885,3 @@
+  // Check if this function has diagnostics that should be emitted when we
+  // codegen it.  If so, don't eit this function definition, but don't emit the
+  // diags just yet.  Emitting an error during codegen stops codegen, and we
"don't do X, but don't do Y" construction sounds awkward to me.
I'd reword the whole comment in terms of what the code does -- if there are diagnostics, only collect them to emit at the end of codegen. Otherwise, proceed to emit function definition.


More information about the cfe-commits mailing list