[PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 8 07:46:27 PDT 2016

aaron.ballman added inline comments.

Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8681-8683
@@ -8680,5 +8676,3 @@
-    return CheckVectorOperands(LHS, RHS, Loc, IsCompAssign,
-                               /*AllowBothBool*/true,
-                               /*AllowBoolConversions*/false);
Are you saying that calling `CheckVectorOperands` was always incorrect? Or that it's no longer required because it should be fully covered by `checkVectorShift`? Because the two methods do considerably different checking, and I would have expected there to be more behavioral differences in the tests by removing the call to `CheckVectorOperands` that suggests there are tests missing.



More information about the cfe-commits mailing list